Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure %license is SPDX compatible #794

Merged

Conversation

TomasTomecek
Copy link
Member

$ askalono crawl LICENSE
LICENSE
License: MIT (original text)
Score: 1.000

https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1

The changelog should propagate to dist-git as the SPDX migration
initiative tracks 'spdx' string in changelogs.

I'm at the SPDX hackfest right now and the guidance I got about the
LICENSE Copyright line was:

  1. it's meaningless and a waste of time to polish
  2. only the "copyright" word has a meaning
  3. the year is meaningless, hence I dropped it
  4. the team name & authors is relevant so I updated it to match 100%
    what we have in the source files

```
$ askalono crawl LICENSE
LICENSE
License: MIT (original text)
Score: 1.000
```

https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1

The changelog should propagate to dist-git as the SPDX migration
initiative tracks 'spdx' string in changelogs.

I'm at the SPDX hackfest right now and the guidance I got about the
LICENSE Copyright line was:
1. it's meaningless and a waste of time to polish
2. only the "copyright" word has a meaning
3. the year is meaningless, hence I dropped it
4. the team name & authors is relevant so I updated it to match 100%
   what we have in the source files

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/3e35f2de52dd48f0afffd778b7ee2a6f

✔️ pre-commit SUCCESS in 1m 44s
ogr-tests-rpm FAILURE in 10m 23s
ogr-tests-pip-deps FAILURE in 11m 11s
✔️ ogr-reverse-dep-packit-tests SUCCESS in 17m 25s

@mfocko
Copy link
Member

mfocko commented Aug 4, 2023

I see 9:36 »GMT« on the failing test… can someone explain to me how did it get 5:36…

@TomasTomecek
Copy link
Member Author

you're right, what's going on here? 👀

image

someone's screwed up timezones badly

@mfocko
Copy link
Member

mfocko commented Aug 4, 2023

@TomasTomecek I think it's time for the required checks to support logical expressions 🙃 especially since TF checks passed

@TomasTomecek
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/5c97c93ea5c34fdebc126480e6e895af

✔️ pre-commit SUCCESS in 1m 41s
ogr-tests-rpm FAILURE in 10m 16s
ogr-tests-pip-deps FAILURE in 10m 55s
✔️ ogr-reverse-dep-packit-tests SUCCESS in 15m 31s

@TomasTomecek TomasTomecek added the mergeit When set, zuul wil gate and merge the PR. label Aug 7, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/1e13f4b3508e451c95cb587e588f12ca

✔️ pre-commit SUCCESS in 1m 46s
ogr-tests-rpm FAILURE in 10m 42s
ogr-tests-pip-deps FAILURE in 11m 19s
✔️ ogr-reverse-dep-packit-tests SUCCESS in 15m 10s

this is what we are seeing in CI tests:
```
AssertionError: assert datetime.datetime(2020, 8, 31, 5, 36, 50) >=
    datetime.datetime(2020, 8, 31, 7, 0)
```

For some reason, the date in CI is 31.8. 5:36 while our test is >= 7:00

locally works fine obviously

I don't have a motivation to track down the root cause, sorry.

I suspect timezones are the root cause.

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/001e12e46e4c43e6bce9eb76f8b9c81f

✔️ pre-commit SUCCESS in 1m 42s
✔️ ogr-tests-rpm SUCCESS in 11m 07s
✔️ ogr-tests-pip-deps SUCCESS in 10m 23s
✔️ ogr-reverse-dep-packit-tests SUCCESS in 14m 34s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/900717aa6f3b44d797dcabb1824b3091

✔️ pre-commit SUCCESS in 1m 43s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit bc6f3eb into packit:main Aug 7, 2023
16 of 18 checks passed
@TomasTomecek TomasTomecek deleted the update-license branch August 7, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants